Document our source for validating printer names

Since the change that got reverted was justified by some cups
documentation, it's important to clearly document where the current
validation scheme comes from (lpadmin man page and cups source).

Also, fix the size check: the cups source code limits this to 127.

1 files changed, 7 insertions, 1 deletions

diff --git a/src/cups.c b/src/cups.c
index 09f0e7b..92425eb 100644
--- a/src/cups.c
+++ b/src/cups.c
@@ -327,6 +327,12 @@ _cph_cups_is_printer_name_valid_internal (const char *name)
         int i;
         int len;
 
+        /* Quoting the lpadmin man page:
+         *    CUPS allows printer names to contain any printable character
+         *    except SPACE, TAB, "/", or  "#".
+         * On top of that, validate_name() in lpadmin.c (from cups) checks that
+         * the string is 127 characters long, or shorter. */
+
         /* no empty string */
         if (!name || name[0] == '\0')
                 return FALSE;
@@ -334,7 +340,7 @@ _cph_cups_is_printer_name_valid_internal (const char *name)
         len = strlen (name);
         /* no string that is too long; see comment at the beginning of the
          * validation code block */
-        if (len > CPH_STR_MAXLEN)
+        if (len > 127)
                 return FALSE;
 
         /* only printable characters, no space, no /, no # */