summaryrefslogtreecommitdiff
authorDan Williams <dcbw@redhat.com>2012-11-27 15:54:51 (GMT)
committer Dan Williams <dcbw@redhat.com>2012-11-27 15:56:25 (GMT)
commitef644fba84544c1a91b3fd2b510e39f9877b3680 (patch) (side-by-side diff)
tree9a6952fb8d39f361c108cc3b85c699db3caac87f
parentc90e41fb1327ad48166b58a8f8281ac6462a9690 (diff)
downloadModemManager-ef644fba84544c1a91b3fd2b510e39f9877b3680.zip
ModemManager-ef644fba84544c1a91b3fd2b510e39f9877b3680.tar.gz
hso: DIAG ports aren't always DIAG
The 'hso' driver tags Icera-based modems' proprietary protocol port as a DIAG port, but since they aren't Qualcomm-based, it's not a DIAG port. Just turn off AT probing and let QCDM probing fail the port instead of assuming it's a DIAG port.
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--plugins/option/mm-plugin-hso.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/plugins/option/mm-plugin-hso.c b/plugins/option/mm-plugin-hso.c
index a11d608..8fe18c4 100644
--- a/plugins/option/mm-plugin-hso.c
+++ b/plugins/option/mm-plugin-hso.c
@@ -89,7 +89,12 @@ hso_custom_init (MMPortProbe *probe,
mm_port_probe_set_result_qcdm (probe, FALSE);
} else if (g_str_has_prefix (contents, "Diag")) {
g_object_set_data (G_OBJECT (probe), TAG_HSO_DIAG, GUINT_TO_POINTER (TRUE));
- mm_port_probe_set_result_qcdm (probe, TRUE);
+ mm_port_probe_set_result_at (probe, FALSE);
+
+ /* Don't automatically tag as QCDM, as the 'hso' driver reports
+ * a DIAG port for some Icera-based modems, which don't have
+ * QCDM ports since they aren't made by Qualcomm.
+ */
}
g_free (contents);
}